Add ament_cmake buildtool_depend tag in metapackage#94
Conversation
GyuH13
commented
Jan 19, 2026
- Add ament_cmake buildtool_depend tag in metapackage for fixing bloom CI build error.
…ing; update changelogs and add ament_cmake as a build dependency.
Summary of ChangesHello @GyuH13, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical build issue in the Bloom CI pipeline by introducing a missing build dependency. The Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly adds ament_cmake as a buildtool_depend to the turtlebot3_machine_learning metapackage to resolve a CI build error. The package versions are consistently updated. I have a couple of minor suggestions to improve the clarity and consistency of the changelog entries.
There was a problem hiding this comment.
Pull request overview
This pull request adds the missing ament_cmake buildtool dependency to the turtlebot3_machine_learning metapackage to resolve bloom CI build errors. The change ensures that the build system correctly declares its dependency on ament_cmake, which is required by the package's CMakeLists.txt file.
Changes:
- Added
buildtool_dependtag for ament_cmake in the metapackage's package.xml - Updated version numbers from 1.0.2 to 1.0.3 across both packages
- Added changelog entries documenting the buildtool_depend addition
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| turtlebot3_machine_learning/package.xml | Added missing ament_cmake buildtool_depend tag and bumped version to 1.0.3 |
| turtlebot3_machine_learning/CHANGELOG.rst | Added changelog entry for version 1.0.3 documenting the buildtool_depend addition |
| turtlebot3_dqn/setup.py | Bumped version to 1.0.3 for consistency with metapackage |
| turtlebot3_dqn/package.xml | Bumped version to 1.0.3 for consistency with metapackage |
| turtlebot3_dqn/CHANGELOG.rst | Added changelog entry for version 1.0.3 with no functional changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.